[staging 1/3 V2] Staging:easycap: fix sparse warnings for module parameters

Dan Carpenter error27 at gmail.com
Tue Jan 18 12:21:00 UTC 2011


On Tue, Jan 18, 2011 at 02:03:23PM +0200, Tomas Winkler wrote:
> easycap_main.c:34:5: warning: symbol 'easycap_debug' was not declared. Should it be static?
> easycap_main.c:36:5: warning: symbol 'easycap_gain' was not declared. Should it be static?
> 
> These two variables actually were declared in several places.
> The variables are used in several files.
> I've fixed "easycap_debug" so it gets declared in one place only and included properly.
> For "easycap_gain" made it static and I created added a
> ->gain member to the easycap struct.  This seems cleaner than using a
> global variable and later on we may make this controlable via sysfs.
> 
> Cc:Mike Thomas <rmthomas at sciolus.org>
> Cc:Dan Carpenter <error27 at gmail.com>
> Signed-off-by: Tomas Winkler <tomas.winkler at intel.com>
> ---

Excelent!  This is exactly the right way to write a patch description.

Acked-by: Dan Carpenter <error27 at gmail.com>

regards,
dan carpenter




More information about the devel mailing list