Linux driver for MAX517/518/519

Jonathan Cameron jic23 at cam.ac.uk
Wed Jan 12 15:44:41 UTC 2011


On 01/12/11 15:34, Greg KH wrote:
> On Wed, Jan 12, 2011 at 11:20:38AM +0000, Jonathan Cameron wrote:
>> On 01/12/11 09:44, Roland Stigge wrote:
>>> Hi,
>>>
>>> On 01/11/2011 08:34 PM, Jonathan Cameron wrote:
>>>>> On 01/09/2011 11:31 PM, Jonathan Cameron wrote:
>>>>>> Pretty clean and nice driver so it was an easy review and should
>>>>>> be trivial to fix up for a merge.
>>>>>
>>>>> Thanks for your review!
>>>>>
>>>>> I'm attaching my update. Some notes:
>>>>>
>>>>> * I used the attributes out1_* how I found it in the other DAC driver
>>>>> already available
>>>> Cool, except for the out12_raw which could easily be the 12th channel.
>>>> This has to be one of the two options suggested the other day.
>>>> May require some macro magic. IIRC the relevant macro would be.
>>>>
>>>> IIO_DEVICE_ATTR_NAMED(out1and2_raw, out1&2_raw, S_IWUSR, ... 
>>>
>>> Update attached as suggested. :-)
>>>
>>> Thanks!
>>>
>>> Roland
>>
>> Probably worth sending it to Greg KH in a new thread so that he
>> picks up on the fact that it is ready to merge. Given the volume
>> of email he probably gets I doubt he is still reading this thread!
>> No need to cc that to the list given we have this email.
> 
> Heh, I'm still here reading this :)
> 
> Roland sent me an updated version, I'll queue that up after .38-rc1 is
> out.
> 
> thanks,
> 
> greg k-h
Thanks. I'm seriously impressed at the number of mails you
must read every day :)

Jonathan
 




More information about the devel mailing list