Linux driver for MAX517/518/519
Roland Stigge
stigge at antcom.de
Wed Jan 12 09:44:29 UTC 2011
Hi,
On 01/11/2011 08:34 PM, Jonathan Cameron wrote:
>> On 01/09/2011 11:31 PM, Jonathan Cameron wrote:
>>> Pretty clean and nice driver so it was an easy review and should
>>> be trivial to fix up for a merge.
>>
>> Thanks for your review!
>>
>> I'm attaching my update. Some notes:
>>
>> * I used the attributes out1_* how I found it in the other DAC driver
>> already available
> Cool, except for the out12_raw which could easily be the 12th channel.
> This has to be one of the two options suggested the other day.
> May require some macro magic. IIRC the relevant macro would be.
>
> IIO_DEVICE_ATTR_NAMED(out1and2_raw, out1&2_raw, S_IWUSR, ...
Update attached as suggested. :-)
Thanks!
Roland
-------------- next part --------------
A non-text attachment was scrubbed...
Name: max517.patch
Type: text/x-patch
Size: 11223 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20110112/ac54d2ea/attachment.bin>
More information about the devel
mailing list