[PATCH 1/5] Staging: comedi: fix line-length coding style issue in usbduxfast.c
Greg KH
gregkh at suse.de
Mon Jan 10 06:36:16 UTC 2011
On Mon, Jan 10, 2011 at 10:03:12AM +1100, ahern.michael.t at gmail.com wrote:
> From: mah <ahern.michael.t at gmail.com>
Please put your "real" name here, the same one you put down below in the
Signed-off-by: line.
> This patch to usbduxfast.c file that fixes warnings found by checkpatch.pl tool
Which warnings?
> -static void usbduxfast_firmware_request_complete_handler(const struct firmware
> +static void usbduxfast_firmware_req_complete_handler(const struct firmware
> *fw, void *context)
> {
> struct usbduxfastsub_s *usbduxfastsub_tmp = context;
> @@ -1577,7 +1585,7 @@ static int usbduxfastsub_probe(struct usb_interface *uinterf,
> &udev->dev,
> GFP_KERNEL,
> usbduxfastsub + index,
> - usbduxfast_firmware_request_complete_handler);
> + usbduxfast_firmware_req_complete_handler);
Renaming the function name just to make the line-length work isn't ok.
Just don't make this change.
thanks,
greg k-h
More information about the devel
mailing list