[patch 2/2] Staging: tm6000: silence Sparse warning "dubious: !x | !y"

Dan Carpenter error27 at gmail.com
Mon Jan 3 05:47:40 UTC 2011


Bitwise and logical or are the equivalent here, so this doesn't affect
runtime, but logical or was intended.  The original code causes a
warning in Sparse:  "warning: dubious: !x | !y"

Signed-off-by: Dan Carpenter <error27 at gmail.com>

diff --git a/drivers/staging/tm6000/tm6000-input.c b/drivers/staging/tm6000/tm6000-input.c
index aee5e85..dae2f1f 100644
--- a/drivers/staging/tm6000/tm6000-input.c
+++ b/drivers/staging/tm6000/tm6000-input.c
@@ -376,7 +376,7 @@ int tm6000_ir_init(struct tm6000_core *dev)
 
 	ir = kzalloc(sizeof(*ir), GFP_KERNEL);
 	rc = rc_allocate_device();
-	if (!ir | !rc)
+	if (!ir || !rc)
 		goto out;
 
 	/* record handles to ourself */



More information about the devel mailing list