[PATCH 07/21] staging: brcm80211: change prototype for wlc_antsel_attach

Arend van Spriel arend at broadcom.com
Fri Feb 25 12:06:06 UTC 2011


On Fri, 25 Feb 2011 12:07:23 +0100, Dan Carpenter <error27 at gmail.com>  
wrote:

> On Fri, Feb 25, 2011 at 11:31:26AM +0100, Arend van Spriel wrote:
>> +struct antsel_info *wlc_antsel_attach(struct wlc_info *wlc)
>> +{
>>  	struct antsel_info *asi;
>>
>>  	asi = kzalloc(sizeof(struct antsel_info), GFP_ATOMIC);
>>  	if (!asi) {
>> -		WL_ERROR("wl%d: wlc_antsel_attach: out of mem\n", pub->unit);
>> +		WL_ERROR("wl%d: wlc_antsel_attach: out of mem\n",
>> +			 asi->pub->unit);
>                          ^^^^^
> Null dereference.  Should be wlc->pub->unit.
>
Please drop this patch. I will fix this and resend it.
>
> regards,
> dan carpenter
>
Good catch. Thanks Dan

Gr. AvS
-- 
"The most merciful thing in the world, I think, is the inability of the  
human
mind to correlate all its contents." - "The Call of Cthulhu"




More information about the devel mailing list