[PATCH 1/6] Staging: hv: vmbus_drv.c Replaced DPRINT with native pr_XXX

Hank Janssen hjanssen at microsoft.com
Wed Feb 23 20:20:32 UTC 2011



> -----Original Message-----
> From: Greg KH [mailto:greg at kroah.com]
> Sent: Wednesday, February 23, 2011 11:12 AM
> To: Hank Janssen
> Why say this in the 1/6 patch?  It should be in the 0/6 introduction.
> 
> >
> > All DPRINT calls have been removed, and where needed have been
> > replaced with pr_XX native calls. Many debug DPRINT calls have
> > been removed outright.
> 
> I think a lot of these pr_XX calls can be switched to dev_XX calls
> instead, right?

Not in this case, this patch set is for vmbus only. The next patch
set will use netdev_* and dev* for netvsc, scsi and IDE.

> How about you break this up into a different series of patches to make
> it more readable:
> 	- remove unneeded DPRINT calls
> 	- convert remaining DPRINT calls to pr_XX or dev_XX as needed
> 
> That would make it easier to review, as it is, it's quite difficult.

Will do.

Hank.




More information about the devel mailing list