[patch 1/2] staging: ath6kl: cleanup in SEND_FRAME ioctl

Greg KH greg at kroah.com
Mon Feb 21 05:02:17 UTC 2011


On Sun, Feb 20, 2011 at 08:45:44PM -0800, Luis R. Rodriguez wrote:
> On Sun, Feb 20, 2011 at 8:14 PM, Greg KH <greg at kroah.com> wrote:
> > On Sun, Feb 20, 2011 at 08:00:38PM -0800, Luis R. Rodriguez wrote:
> >> On Sun, Feb 20, 2011 at 7:18 AM, Vipin Mehta <vmehta at atheros.com> wrote:
> >> > On Sun, Feb 20, 2011 at 04:49:08AM -0800, Dan Carpenter wrote:
> >> >> The original code was written in a funny way where every statement was
> >> >> part of else if blocks.  I broke them up into separate statements by
> >> >> adding breaks on failure conditions.
> >> >>
> >> >> Signed-off-by: Dan Carpenter <error27 at gmail.com>
> >>
> >> Can you guys please join IRC? ...
> >
> > That is not a requirement for kernel development, sorry.
> 
> No, but I'm not asking you, I'm asking Vipin and other developers,
> using IRC is a good idea for internal coordination.

I agree, but that wasn't what you said here :)

> I see no way Vipin checking with Joe if he had his first set of
> patches ready. We need to do major cleanup on the driver *now* and
> these sort of miscommunication is just irritating. How do you
> recommend we coordinate cleanup with random patches being ACKed in the
> process without proper coordination?

You get Joe and Vipin to work together and agree with what to do.  You
don't email 4 other people and 2 mailing lists with a request to join
IRC :)

It's not like we don't do this kind of things all the time, and have
been for years, it just takes a willingness for the people involved to
work together.  Hopefully that is the case here.

thanks,

greg k-h



More information about the devel mailing list