[PATCH]: Staging: hv: Allocate the vmbus irq dynamically
Greg KH
gregkh at suse.de
Fri Feb 18 22:07:24 UTC 2011
On Fri, Feb 18, 2011 at 10:00:04PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Greg KH [mailto:greg at kroah.com]
> > Sent: Friday, February 18, 2011 4:14 PM
> > To: KY Srinivasan
> > Cc: gregkh at suse.de; linux-kernel at vger.kernel.org;
> > devel at linuxdriverproject.org; virtualization at lists.osdl.org
> > Subject: Re: [PATCH]: Staging: hv: Allocate the vmbus irq dynamically
> >
> > On Tue, Feb 15, 2011 at 11:55:35AM -0800, K. Y. Srinivasan wrote:
> > >
> > > Signed-off-by: K. Y. Srinivasan <kys at microsoft.com>
> > > Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com>
> > > Signed-off-by: Hank Janssen <hjanssen at microsoft.com>
> >
> > You didn't run this through checkpatch.pl.
> >
> > Please do so and fix the warning it gives you.
> Greg, I did run the checkpatch script against this patch and the only
> complaint I got was with regards to the IRQF_SAMPLE_RANDOM flag that I
> pass. As a virtual machine, this is the only external event that the
> VM is going to see and so I chose to keep this flag. Is there
> something that would replace this flag; looking at the Xen drivers
> they do pass this flag.
But that flag is going away, right? And this really can't be a valid
source of entropy as the HV channel is pretty predictable.
If you are only using this because Xen does/did it, that's not a valid
excuse :)
thanks,
greg k-h
More information about the devel
mailing list