[PATCH2 1/3] staging: brcm80211: remove warning introduced by rfkill implementation

Greg KH greg at kroah.com
Fri Feb 18 20:55:19 UTC 2011


On Thu, Feb 10, 2011 at 03:27:44PM +0100, Arend van Spriel wrote:
> During rfkill implementation the content of wlc_radio_upd function
> was removed for testing purposes only. This ended up in the patch
> sent out. This commit restores the function content, which was the
> only function calling static function wlc_radio_enable. This removes
> the compilation warning observed.
> 
> Reviewed-by: Brett Rudley <brudley at broadcom.com>
> Reviewed-by: Roland Vossen <rvossen at broadcom.com>
> Signed-off-by: Arend van Spriel <arend at broadcom.com>
> ---
>  drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c b/drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c
> index 4c174a3..48d2da6 100644
> --- a/drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c
> +++ b/drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c
> @@ -2311,6 +2311,11 @@ void wlc_radio_mpc_upd(struct wlc_info *wlc)
>   */
>  static void wlc_radio_upd(struct wlc_info *wlc)
>  {
> +	if (wlc->pub->radio_disabled) {
> +		wlc_radio_disable(wlc);
> +	} else {
> +		wlc_radio_enable(wlc);
> +	}

You obviously didn't run this through checkpatch, which is sad, because
now you will have to send another patch to fix this up later.

Unless that's your plan all along...

thanks,

greg k-h



More information about the devel mailing list