[PATCH] brcm80211: remove multiple calls to wl_release_fw
Dan Carpenter
error27 at gmail.com
Mon Feb 14 21:20:05 UTC 2011
On Tue, Feb 15, 2011 at 12:07:55AM +0300, Stanislav Fomichev wrote:
> > This patch isn't right. It fixes the oops but it introduces some leaks.
> > (We still need to release firmware that was allocated successfully).
> Sorry Dan, but where do you see the leaks? We make a call to
> wl_request_fw and if returns non-zero call wl_release_fw for a cleanup.
>
> I just removed the call to wl_release_fw in the wl_request_fw itself; so
> it should not introduce any leak.
>
> Could you pls clarify?
Ah. Right. I see what you're saying. Your patch looks good to me.
regards,
dan carpenter
More information about the devel
mailing list