[PATCH] staging: brcm80211: BUGFIX for issue that the system is frozen when it trys to enter into suspend mode.

Dowan Kim dowan at broadcom.com
Thu Feb 10 20:27:18 UTC 2011


Present code in the ROOT/driver/staging/brcm80211/brcmfmac/wl_cfg80211.c,
suppports two types of FULLMAC-type board. One is the 4329 reference board
which can be tested both on x86 system and ARM as long as it has ARASAN
sdio interface and the other is the module mounted on TEGRA2-SEABOARD platform.

The bug was reported from test team of TEGRA2-SEABOARD platform when the
development team implemented SUSPEND/RESUME function of TEGRA2 based on mainline
kernel version 2.6.36 with Google CHROMIUM platform.

The fix was tested with the staging-next sources in
/linux/kernel/git/gregkh/staging-2.6.git

Dowan

-----Original Message-----
From: Greg KH [mailto:greg at kroah.com] 
Sent: Thursday, February 10, 2011 12:06 PM
To: Dowan Kim
Cc: linux driver project; Brett Rudley; Henry Ptasinski; Venkat Rao; Roland Vossen
Subject: Re: [PATCH] staging: brcm80211: BUGFIX for issue that the system is frozen when it trys to enter into suspend mode.

On Thu, Feb 10, 2011 at 11:55:31AM -0800, Dowan Kim wrote:
> Signed-off-by: Dowan Kim <dowan at broadcom.com>
> ---
>    drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c |    2 --
>    1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
> b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
> index fa2316b..847036f 100644
> --- a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
> +++ b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
> @@ -1979,8 +1979,6 @@ static s32 wl_cfg80211_suspend(struct wiphy *wiphy)
>           struct net_device *ndev = wl_to_ndev(wl);
>           s32 err = 0;
> 
> -       CHECK_SYS_UP();
> -

I don't understand, how is this a bugfix?  What does this solve?  Why
was this code originally here if it is wrong?

And what tree is this for?

You need to provide a whole lot more information here.

greg k-h





More information about the devel mailing list