Asus OLED

[Kevyn-Alexandre Paré]

On Tue, Feb 8, 2011 at 12:03 PM, Kevyn-Alexandre Paré
<kevyn.alexandre.pare at gmail.com> wrote:
> On Mon, Feb 7, 2011 at 8:35 PM, Greg KH <greg at kroah.com> wrote:
>> On Mon, Feb 07, 2011 at 06:48:06PM -0500, Kevyn-Alexandre Paré wrote:
>>> Hi Can some one help me to answer these question?
>>>
>>>
>>> drivers/staging/asus_oled/TODO:
>>>     - checkpatch.pl cleanups
>>> CHECK nothing to do (DONE):
>>> ./scripts/checkpatch.pl --terse --file drivers/staging/asus_oled/asus_oled.c
>>
>> Great, send a patch removing this from the TODO file.
>>
>
> Will do!
>
>>>     - sparse fixes
>>> What's that???
>>
>> A tool that does a bunch of build-time detection of problems and
>> potential errors.  Install it and then build the kernel with "C=1" on
>> the command line and it will show you the warnings, if any.
>>
>
> A ok, reading about it right now:
> Documentation/sparse.txt
>

Tested and no warning found with sparse v0.4.3 (last from git)
make C=2 SUBDIRS=drivers/staging/asus_oled asus_oled.ko

I will remove this one to for the TODO patch...

>>>     - audit the userspace interface
>>> Who should do this? The user interface is with sysfs clearly explain
>>> in the README (/sys/class/asus_oled/oled_N).
>>
>> I can look at it later after the sparse work.
>>
>
> Will sparse and keep you inform..

Done

>
>>>     - sysfs vs. char?
>>> Who should decide? If we need to switch it to char I'm willing to do it.
>>
>> If the sysfs interface is deemed good, no need.
>>
>
> k
>
>>>     - Documentation/ABI/ needs to be added
>>> and formating it to fit with ABI... If I understand correctly we
>>> should grab the information from README and format it properly to be
>>> inserted into Documentation/ABI/testing/sysfs-class-asus_oled???
>>
>> Yes.
>>
>
> Will start writing it!
>
>> thanks,
>>
>> greg k-h
>>
>