[PATCH 4/5] staging: ft1000: Fix coding style in write_blk_fifo() function.

Dan Carpenter error27 at gmail.com
Wed Feb 9 11:08:34 UTC 2011


On Wed, Feb 09, 2011 at 11:07:19AM +0100, Belisko Marek wrote:
> Well I test it and it seems very strange and can't figure out why.
> Will remove all byte_length manipulations and device doesn't boot properly
> (finish with error). Add some prinkt to code figure out following:
> 
> 1. byte_length = word_length *4 is < 64 we need to send via usb 68
> bytes (despite
> 4 bytes are behind 64 (without this it can't boot).
> 
> 2. also when e.g. word_length is 400 (400*4 = 1600) condition
> 1600%64 == 0 is valid and we send 1604 bytes to usb (also not sure why
> but without this change it also doesn't work).
> 

Huh.  Strange.  Thanks for testing.  Sorry for the noise.

regards,
dan carpenter





More information about the devel mailing list