[staging-next 11/12] staging/easycap: use regget for register back reading

Dan Carpenter error27 at gmail.com
Wed Feb 9 00:11:47 UTC 2011


On Wed, Feb 09, 2011 at 01:12:50AM +0200, Tomas Winkler wrote:
> +	rc1 = regget(pusb_device, index, &igot, sizeof(igot));

You didn't introduce this either but &igot is a stack address and it's
a bug on some arches to use stack addresses for DMA.  This is documented
in Documentation/DMA-API-HOWTO.txt

It seems like it should be documented with usb_control_msg() though if
it were actually an issue, so perhaps I'm wrong on this point.

regards,
dan carpenter




More information about the devel mailing list