[staging-next 09/12] staging/eascap: add first level indentation to regget/set functions

Dan Carpenter error27 at gmail.com
Tue Feb 8 23:47:52 UTC 2011


On Wed, Feb 09, 2011 at 01:12:48AM +0200, Tomas Winkler wrote:
> +
> +	return 0xFF & rc;

You didn't introduce this, but it's wrong.  It's masking out negative
error codes.  The caller does check for error codes.  Probably it 
would make more sense to just return rc directly...  I'm not sure what
was intended here.

regards,
dan carpenter





More information about the devel mailing list