[staging-next 02/12] staging/easycap: prefer printk over SAY in module entry functions

Tomas Winkler tomas.winkler at intel.com
Tue Feb 8 23:12:41 UTC 2011


Use INFO level when registering driver and ERR for error.
Drop messages from oneliner exit function

Cc: Mike Thomas <rmthomas at sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler at intel.com>
---
 drivers/staging/easycap/easycap_main.c |   12 +++---------
 1 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/easycap/easycap_main.c b/drivers/staging/easycap/easycap_main.c
index cfdbb57..4385236 100644
--- a/drivers/staging/easycap/easycap_main.c
+++ b/drivers/staging/easycap/easycap_main.c
@@ -4829,10 +4829,10 @@ static int __init easycap_module_init(void)
 {
 	int k, rc;
 
-	SAY("========easycap=======\n");
+	printk(KERN_INFO "Easycap version: "EASYCAP_DRIVER_VERSION "\n");
+
 	JOT(4, "begins.  %i=debug %i=bars %i=gain\n",
 		easycap_debug, easycap_bars, easycap_gain);
-	SAY("version: " EASYCAP_DRIVER_VERSION "\n");
 
 	mutex_init(&mutex_dongle);
 	for (k = 0; k < DONGLE_MANY; k++) {
@@ -4840,22 +4840,16 @@ static int __init easycap_module_init(void)
 		mutex_init(&easycapdc60_dongle[k].mutex_video);
 		mutex_init(&easycapdc60_dongle[k].mutex_audio);
 	}
-	JOT(4, "registering driver easycap\n");
 	rc = usb_register(&easycap_usb_driver);
 	if (rc)
-		SAY("ERROR:  usb_register returned %i\n", rc);
+		printk(KERN_ERR "Easycap: usb_register failed rc=%d\n", rc);
 
-	JOT(4, "ends\n");
 	return rc;
 }
 /*****************************************************************************/
 static void __exit easycap_module_exit(void)
 {
-	JOT(4, "begins\n");
-
 	usb_deregister(&easycap_usb_driver);
-
-	JOT(4, "ends\n");
 }
 /*****************************************************************************/
 
-- 
1.7.4

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.




More information about the devel mailing list