[PATCH RFC] staging: olpc_dcon: Remove _strtoul() function.

Belisko Marek marek.belisko at gmail.com
Tue Feb 8 12:02:37 UTC 2011


On Tue, Feb 8, 2011 at 12:23 PM, Dan Carpenter <error27 at gmail.com> wrote:
> On Tue, Feb 08, 2011 at 12:06:00PM +0100, Marek Belisko wrote:
>> olpc_dcon driver use self invented _strtoul  function
>> which make similar check like strict_strtoul just extend
>> for space checking at last string place. Normally access
>> to sys file looks echo 1024 > /sys/... so space could be considered
>> as error character and we could simplify code using just strict_strtoul
>> function instead self invented.
>>
>
> Could you do it on top of the patches that Andres Salomon sent?
patch resend : http://driverdev.linuxdriverproject.org/pipermail/devel/2011-February/011930.html
>
> http://driverdev.linuxdriverproject.org/pipermail/devel/2011-February/thread.html
>
> # [PATCH 1/4] olpc_dcon: get rid of global i2c_client, create a dcon_priv struct   Andres Salomon
> # [PATCH 2/4] olpc_dcon: change sysfs 'output' toggle to be clearer...   Andres Salomon
> # [PATCH 3/4] olpc_dcon: move more variables into dcon_priv   Andres Salomon
> # [PATCH 4/4] olpc_dcon: actually return the value of i2c_add_driver   Andres Salomon
>
> regards,
> dan carpenter
>
>
>

thanks,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com



More information about the devel mailing list