[PATCH 3/4] staging: brcm80211: removed 32 bit DMA functions

Dan Carpenter error27 at gmail.com
Tue Feb 1 10:14:16 UTC 2011


On Tue, Feb 01, 2011 at 10:32:30AM +0100, Roland Vossen wrote:
> Code cleanup. Removed unused functions.
> 
> Signed-off-by: Roland Vossen <rvossen at broadcom.com>
> ---

> @@ -2471,24 +1804,8 @@ uint dma_addrwidth(si_t *sih, void *dmaregs)
>  			    ((sih->bustype == PCI_BUS) &&
>  			     (sih->buscoretype == PCIE_CORE_ID)))
>  				return DMADDRWIDTH_64;
> -
> -		/* DMA64 is always 32-bit capable, AE is always true */
> -		ASSERT(_dma64_addrext(osh, (dma64regs_t *) dmaregs));
> -
> -		return DMADDRWIDTH_32;
>  	}
> -
> -	/* Start checking for 32-bit / 30-bit addressing */
> -	dma32regs = (dma32regs_t *) dmaregs;
> -
> -	/* For System Backplane, PCIE bus or addrext feature, 32-bits ok */
> -	if ((sih->bustype == SI_BUS) ||
> -	    ((sih->bustype == PCI_BUS)
> -	     && sih->buscoretype == PCIE_CORE_ID)
> -	    || (_dma32_addrext(osh, dma32regs)))
> -		return DMADDRWIDTH_32;
> -
> -	/* Fallthru */
> -	return DMADDRWIDTH_30;
> +	ASSERT(0); /* DMA hardware not supported by this driver*/
> +	return DMADDRWIDTH_64;
>  }

This isn't an unused function.  Could you explain in your change log
what you are doing here?  Probably it should be a separate commit.

regards,
dan carpenter





More information about the devel mailing list