[staging-next 1/4] staging: easycap: don't cast NULL pointer

Winkler, Tomas tomas.winkler at intel.com
Tue Feb 1 05:39:02 UTC 2011



> -----Original Message-----
> From: Greg KH [mailto:greg at kroah.com]
> Sent: Tuesday, February 01, 2011 12:01 AM
> To: Winkler, Tomas
> Cc: gregkh at suse.de; devel at linuxdriverproject.org
> Subject: Re: [staging-next 1/4] staging: easycap: don't cast NULL pointer
> 
> On Tue, Jan 25, 2011 at 05:33:27PM +0200, Tomas Winkler wrote:
> > Signed-off-by: Tomas Winkler <tomas.winkler at intel.com>
> 
> Something in this patch series causes the following build breakage to
> happen:
> drivers/staging/easycap/easycap_sound_oss.c:711:29: error: expected ‘=’,
> ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘ioctl’
> drivers/staging/easycap/easycap_sound_oss.c:1009:20: error:
> ‘easyoss_unlocked_ioctl’ undeclared here (not in a function)
> make[3]: *** [drivers/staging/easycap/easycap_sound_oss.o] Error 1

Hmm, looks like broken comment or something like that...here compiles everything fine.
Sorry for troubles I will check that again.

> 
> Care to fix it up and resend _all_ of the easycap patches you have sent
> to me but that I haven't applied?  I've purged them all from my to-apply
> queue as I don't want to mess with picking some and not others as that
> gets messy really quickly.

Sure.
> 
> Also, are you working with the original author of this driver to do this
> work?  If not, please do so.

Mike has expressed in a private conversation and also on this list that he has no more time
to working on this project so I've dropped him from the CC list. 

Thanks
Tomas

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


More information about the devel mailing list