[PATCH] staging:iio: Setup buffer access functions when allocating the buffer

Greg KH greg at kroah.com
Tue Dec 13 00:46:59 UTC 2011


On Mon, Dec 12, 2011 at 11:09:05AM +0100, Lars-Peter Clausen wrote:
> Setup the buffer access functions in the buffer allocate function. There is no
> need to let each driver handle this on its own.

That's nicer.

So, you have different ways to have "buffers" and the driver doesn't
know what type you have, and it's chosen at build time?  Why are you
making the kernel builder make such a decision?  Why not just pick one,
that you know works well, and use it?

You would get rid of a whole level of indirection that I really don't
think you need at all, right?

Make a decision, don't force someone else to make it for you...

greg k-h



More information about the devel mailing list