[PATCH 2/3] staging:iio:kfifo_buf: Fix potential buffer overflow in iio_read_first_n_kfifo

Greg KH greg at kroah.com
Fri Dec 9 15:11:18 UTC 2011


On Fri, Dec 09, 2011 at 10:58:19AM +0100, Lars-Peter Clausen wrote:
> On 12/08/2011 09:17 PM, Greg KH wrote:
> > On Thu, Dec 08, 2011 at 06:35:52PM +0100, Lars-Peter Clausen wrote:
> >> n is the number of bytes to read, not the number of samples. So if there is
> >> enough data available we will write to the userspace buffer beyond its bounds.
> >> Fix this by copying n bytes maximum. Also round n down to the next multiple of
> >> the sample size, so we will only read complete samples. If the buffer is too
> >> small to hold at least one sample return -EINVAL.
> >>
> >> Also update the documentation of read_first_n to reflect the fact that 'n' is
> >> supposed to be in bytes and not in samples.
> >>
> >> Acked-by: Jonathan Cameron <jic23 at kernel.org>
> >> Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
> >> ---
> >>  drivers/staging/iio/buffer.h    |    2 +-
> > 
> > This patch no longer applies to my tree, care to refresh it and resend
> > it?
> 
> Hi Greg,
> 
> I just rebased the patch on top of the current staging-next and it is
> identically to this one. Could you try to re-apply it, if you still have it?
> Otherwise I'll send it out again.

Can you resend it?  I don't know what I did wrong here...

greg k-h



More information about the devel mailing list