[PATCH v2] staging: tidspbridge: request dmtimer clocks on init

Ramirez Luna, Omar omar.ramirez at ti.com
Thu Dec 8 19:10:04 UTC 2011


On Wed, Dec 7, 2011 at 4:11 PM, Felipe Contreras
<felipe.contreras at gmail.com> wrote:
> On Sat, Nov 19, 2011 at 12:18 AM, Omar Ramirez Luna <omar.ramirez at ti.com> wrote:
>> Given that dm timer framework doesn't support request of clocks
>> by soft | hard irqs because some recent changes, tidspbridge needs
>> to request its clocks on init and enable/disable them on demand.
>>
>> This was first seen on 3.2-rc1.
>>
>> Signed-off-by: Omar Ramirez Luna <omar.ramirez at ti.com>
>
> This looks similar similar to this one:
> http://article.gmane.org/gmane.linux.ports.arm.omap/61816
>
> Are you sure this is what we want instead of that one?

I believe your patch only takes care of gpt5 and gpt6, but not of the
other 2 that could be requested by the dsp, let's say gpt8 for avsync.

As for this patch, dm timer framework should support request on soft
or hard irq[1], but it can't because the underlying functions to use
clk_get->clk_get_sys which holds a mutex.

I believe your error was seen because of patches not in mainline, but
the concept between the patches is similar indeed, however mine:

- Handles the other gpt that can be requested by the dsp.
- Uses start/stop according to future plans of making enable/disable static.
- Might be temporal if *dm_timer_request* functions are fixed and
there is an overall feeling that we can revert to use
request+start/stop+free on request.

Regards,
Omar,
---
[1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg58665.html



More information about the devel mailing list