[PATCH] staging: bcm: led_control.c: coding style cleanup

[Dan Carpenter]

On Tue, Dec 06, 2011 at 11:45:19AM +0100, Johannes Tenschert wrote:
> Hi,
>  
> this patch contains coding style fixes (indentation, placing of braces
> and spaces, breaking long lines) in led_control.c.
>  
> It fixes most warnings and all errors of scripts/checkpatch.pl. "Most"
> warnings because parts of the file are highly nested and those lines would
> be unreadable if they were fixed.
>  
> Signed-off-by: Johannes Tenschert <Johannes.Tenschert at informatik.stud.uni-erlangen.de>
>  
> Parent is caca6a03d365883564885f2c1da3e88dcf65d139 : Linux 3.2-rc3
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Put this under the --- marks.  git am automatically removes that
stuff.  Also always write your patch against linux-next.  This
applies fine as is so it's not a big deal.

I've reviewed this patch and it is all good stuff and doesn't
introduce any bugs, but it's too much.  1000 lines of changes is
annoying to review.

Could you break it up into several patches:
1) fix the comments
2) white space fixes
3) parens
etc.

Part of the problem with a huge patch is that I feel bad asking
people to redo it, but actually could you please?  I'm not going to
enjoy reviewing it the second time either, but that's pretty much
our response whenever anyone sends us a patch like this.

regards,
dan carpenter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20111207/196b3411/attachment.asc>