[PATCH 2/2] Staging: olpc_dcon.c: obsolete use of strict_stroul; resumeline
Dan Carpenter
dan.carpenter at oracle.com
Sun Dec 4 15:47:27 UTC 2011
On Sun, Dec 04, 2011 at 12:17:33PM +0100, Valentin Rothberg wrote:
> As Dan mentioned, dcon_write() will only write u16 values. The
> appropriate parts have been changed. As a result of module_param()
> not accepting u16 as a valid data type, unsigned short is used.
>
> Signed-off-by: Valentin Rothberg <valentinrothberg at googlemail.com>
> ---
> drivers/staging/olpc_dcon/olpc_dcon.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index 1e64992..1b3847b 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -34,8 +34,8 @@
>
> /* Module definitions */
>
> -static int resumeline = 898;
> -module_param(resumeline, int, 0444);
> +static unsigned short resumeline = 898;
> +module_param(resumeline, unsigned short, 0444);
This breaks the compile. You have to use ushort like I explained
before.
regards,
dan carpenter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20111204/5d2120dc/attachment.asc>
More information about the devel
mailing list