[PATCH 20/20] staging: rtl8192e: Cleanup checkpatch -f warnings and errors - Part XVIII

Greg KH gregkh at suse.de
Tue Aug 30 15:40:07 UTC 2011


On Tue, Aug 30, 2011 at 06:21:43PM +0300, Dan Carpenter wrote:
> On Thu, Aug 25, 2011 at 11:48:30AM -0500, Larry Finger wrote:
> > @@ -68,81 +64,73 @@ int rtl8192E_suspend (struct pci_dev *pdev, pm_message_t state)
> >  		write_nic_byte(dev, MacBlkCtrl, 0xa);
> >  	}
> >  out_pci_suspend:
> > -	RT_TRACE(COMP_POWER, "r8192E support WOL call??????????????????????\n");
> >  	printk("r8192E support WOL call??????????????????????\n");
> > -	if (priv->rtllib->bSupportRemoteWakeUp) {
> > -		RT_TRACE(COMP_POWER, "r8192E support WOL call!!!!!!!!!!!!!!!!!!.\n");
> > -	}
> > +	if (priv->rtllib->bSupportRemoteWakeUp)
> > +		RT_TRACE(COMP_POWER, "r8192E support WOL call!!!!!!!"
> > +			 "!!!!!!!!!!!.\n");
> 
> Kernel style says you should never use more than 15 exclamation marks
> but there are 18 here.  And a period.

Best review comment ever.



More information about the devel mailing list