[PATCH 3/3] staging: vme: make match() driver specific to improve non-VME64x support
Manohar Vanga
manohar.vanga at cern.ch
Tue Aug 30 10:39:29 UTC 2011
> Here there seems to be a missing kfree(vdev), like the one after device_unregister()
> a few lines earlier.
> > + if (!err & (drv->ndev == 0))
>
> Probably you meant if (!err && drv->ndev == 0) here.
Ah darn. Will fix and resend.
> In fact one could imagine a driver that has no devices when it's
> installed (it might get them later); so I'd remove this check.
Yeah I suppose with VME64x it's possible. Will remove.
--
/manohar
More information about the devel
mailing list