[PATCHv2 2/3] staging: bcm: move extern declaration from Bcmchar.c file into headers.h file reported by checkpatch.pl tool

Kevin McKinney klmckinney1 at gmail.com
Wed Aug 24 00:01:43 UTC 2011


Hi Greg,

On Tue, Aug 23, 2011 at 6:19 PM, Greg KH <greg at kroah.com> wrote:
> On Mon, Aug 15, 2011 at 10:10:12PM -0400, Kevin McKinney wrote:
>> commit 9c474c6d3d993748c07135acf8c4a40e693a56f0
>> Author: Kevin McKinney <klmckinney1 at gmail.com>
>> Date:   Sun Aug 14 21:05:01 2011 -0400
>>
>>     Staging: bcm: Fix a coding style error reported by checkpatch.pl
>>
>>     Tool checkpatch.pl reported the following error: extern struct class *bcm_class;"
>>     declaration not allowed in .c files. Therefore, I move this declaration into
>>     the header "headers.h" file.
>>
>>     Signed-off-by: Kevin McKinney <klmckinney1 at gmail.com>
>>
>
>
> In the future, don't send out patches that look like this, I need to
> edit this by hand to apply it properly.
>
> Use 'git format-patch' or 'git sendmail' to do it in email format, not
> in this format where I need to strip off the date, commit, author, and
> move the text to the left.
>
> Don't worry for these three, but in the future, please be more careful.

I will use git format-patch in the future.

Thanks,
Kevin
>



More information about the devel mailing list