staging/quatech_usb2: right shift warning

Greg KH greg at kroah.com
Tue Aug 23 19:56:10 UTC 2011


On Wed, Jul 13, 2011 at 08:56:59AM -0700, Randy Dunlap wrote:
> [how does one reach Tim Gobeli at Quatech?
> I can't find his contact info.]

I do not know, sorry.

> drivers/staging/quatech_usb2/quatech_usb2.c:761:42: warning: right shift by bigger than source value
> 
> 	header_array[4] = (__u8)count >> 8;
> 
> That should be more like:
> 
> 	header_array[4] = (__u8)(count >> 8);

I agree, care to make a patch?

greg k-h



More information about the devel mailing list