[PATCHv2 2/3] staging: bcm: move extern declaration from Bcmchar.c file into headers.h file reported by checkpatch.pl tool
kmckinney2 at sc.rr.com
kmckinney2 at sc.rr.com
Mon Aug 15 01:37:39 UTC 2011
commit 9c474c6d3d993748c07135acf8c4a40e693a56f0
Author: Kevin McKinney <klmckinney1 at gmail.com>
Date: Sun Aug 14 21:05:01 2011 -0400
Staging: bcm: Fix a coding style error reported by checkpatch.pl
Tool checkpatch.pl reported the following error: extern struct class *bcm_class;"
declaration not allowed in .c files. Therefore, I move this declaration into
the header "headers.h" file.
Signed-off-by: Kevin McKinney <klmckinney1 at gmail.com>
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 4bcc38b..d3f3856 100644
--- a/drivers/staging/bcm/Bcmchar.c
+++ b/drivers/staging/bcm/Bcmchar.c
@@ -1974,8 +1974,6 @@ static const struct file_operations bcm_fops = {
.llseek = no_llseek,
};
-extern struct class *bcm_class;
-
int register_control_device_interface(PMINI_ADAPTER Adapter)
{
diff --git a/drivers/staging/bcm/headers.h b/drivers/staging/bcm/headers.h
index 947d063..da47db8 100644
--- a/drivers/staging/bcm/headers.h
+++ b/drivers/staging/bcm/headers.h
@@ -74,4 +74,6 @@
#define DRV_VERSION VER_FILEVERSION_STR
#define PFX DRV_NAME " "
+extern struct class *bcm_class;
+
#endif
More information about the devel
mailing list