[patch] Staging: iio/dac/ad5504: uninitialized variable in error handling

Dan Carpenter error27 at gmail.com
Tue Aug 9 18:06:16 UTC 2011


If we hit the "goto error_disable_reg" then the "st" variable is
uninitialized.

Signed-off-by: Dan Carpenter <error27 at gmail.com>

diff --git a/drivers/staging/iio/dac/ad5504.c b/drivers/staging/iio/dac/ad5504.c
index 1915f45..88512dd 100644
--- a/drivers/staging/iio/dac/ad5504.c
+++ b/drivers/staging/iio/dac/ad5504.c
@@ -338,7 +338,7 @@ error_free_dev:
 	iio_free_device(indio_dev);
 error_disable_reg:
 	if (!IS_ERR(reg))
-		regulator_disable(st->reg);
+		regulator_disable(reg);
 error_put_reg:
 	if (!IS_ERR(reg))
 		regulator_put(reg);



More information about the devel mailing list