[PATCH v3 1/3] staging: brcm80211: replaced WL_NONE with no_printk

[Joe Perches]

On Thu, 2011-04-21 at 13:02 +0200, Roland Vossen wrote:
[]
> diff --git a/drivers/staging/brcm80211/brcmsmac/wl_dbg.h b/drivers/staging/brcm80211/brcmsmac/wl_dbg.h
> index 54af257..8705b40 100644
> --- a/drivers/staging/brcm80211/brcmsmac/wl_dbg.h
> +++ b/drivers/staging/brcm80211/brcmsmac/wl_dbg.h
> @@ -20,8 +20,6 @@
>  /* wl_msg_level is a bit vector with defs in wlioctl.h */
>  extern u32 wl_msg_level;
>  
> -#define WL_NONE(fmt, args...) no_printk(fmt, ##args)
> -

I think you misunderstand the purpose of no_printk.
no_printk is used simply to validate format arguments
and not emit anything.

It's typically used for debugging like

#ifndef DEBUG
#define FOO_DBG(fmt, ...)	printk(fmt, ##__VA_ARGS__)
#else
#define FOO_DBG(fmt, ...)	no_printk(fmt, ##__VA_ARGS__)
#endif

What you've got here is effectively a comment.

More likely there was a mistake in the initial
conversion to of WL_NONE to no_printk.