[PATCH 2/3] staging: brcm80211: making device object accessible from wlc and phy

Roland Vossen rvossen at broadcom.com
Thu Apr 21 09:31:05 UTC 2011


On 04/20/2011 11:10 PM, Greg KH wrote:
> Whenever you save off a pointer to a struct device that you do not own,
> you MUST increase the reference count, otherwise it could disappear
> underneath you and you would never know it.
>
> So please do the proper increment/decrement when you are messing with
> stuff like this, otherwise debugging your driver errors on unexpected
> device removal is going to be a nightmare.

Thanks for the remark. Will do that in an upcoming v2 patch series.

I have a question: I grepped the directories:

net/mac80211, drivers/net/wireless and drivers/staging

for the following terms:

'kobj'
'get_device'

but see very little calls to get_device() or kobj_*() functions. Does 
that match your expectation ?

Thanks, Roland.





More information about the devel mailing list