[PATCH 2/2] staging: Add Snappy compression support to zram

Greg KH greg at kroah.com
Fri Apr 15 22:33:24 UTC 2011


On Sat, Apr 16, 2011 at 12:50:51AM +0300, Zeev Tarantov wrote:
> From: Zeev Tarantov <zeev.tarantov at gmail.com>
> 
> Zram currently uses LZO compression. With Snappy, it uses less CPU time and is
> thus more useful. The sacrifice in compression ratio is small.
> Zram's LZO and Snappy support can be independently enabled at compile time and
> each zram device can switch between compression methods when unused.
> When only a single compression method was enabled at compile time, no idirection
> penalty is incurred.

Ick, why have the ability to switch at all, that just adds lots of code
complexity and mess.

Please just switch to the new mode if it's always faster and better.
That should make your patch easier to read and understand.

thanks,

greg k-h



More information about the devel mailing list