[PATCH v2 3/3] staging: brcm80211: replaced WL_ERROR with dev_err in two files

Roland Vossen rvossen at broadcom.com
Fri Apr 8 07:10:27 UTC 2011


>> +		wiphy_err(hw->wiphy, "%s: wl_up() returned %d\n", __func__,
>> +			  err);
>
> Is emitting __func__ really useful?
> I don't think so.

That is perhaps debatable, but since this is debug functionality, and we 
are discussing a parameter in a printf-like statement, I wonder if it is 
worth the debate. Will keep it in mind for future submissions.

Thanks, Roland.




More information about the devel mailing list