[PATCH 3/3] staging: brcm80211: replaced WL_ERROR with dev_err in two files.

Joe Perches joe at perches.com
Fri Apr 1 08:48:48 UTC 2011


On Fri, 2011-04-01 at 10:35 +0200, Roland Vossen wrote:
> Code cleanup. Use Linux function instead of Broadcom specific
> one. On spots where the device object is not yet available,
> pr_err() is used instead.

Perhaps use wiphy_<level> when possible.

> diff --git a/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c b/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c
[]
> @@ -205,8 +207,8 @@ wl_ops_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
>  	    vif->type != NL80211_IFTYPE_STATION &&
>  	    vif->type != NL80211_IFTYPE_WDS &&
>  	    vif->type != NL80211_IFTYPE_ADHOC) {
> -		WL_ERROR("%s: Attempt to add type %d, only STA for now\n",
> -			 __func__, vif->type);
> +		dev_err(&hw->wiphy->dev, "%s: Attempt to add type %d, only"
> +			" STA for now\n", __func__, vif->type);

		wiphy_err(hw->wiphy, "%s: Attempt to add type %d, only STA for now\n",
			  __func__, vif->type);

etc...




More information about the devel mailing list