[PATCH] staging: brcm80211:fix #ifdef BRCM_FULLMAC mess

Greg KH greg at kroah.com
Thu Sep 30 11:45:10 UTC 2010


On Wed, Sep 29, 2010 at 03:56:49PM -0700, nohee ko wrote:
> This patch fixes "#ifdef BRCM_FULLMAC" mess which shows
> in siutils.c/hndpmu.c.
> All unnecessary #ifdefs were erased.
> Also as a part of this work, bcmutils.c was also modified.

Ok, that's a nice description, but then:

> >From bc8ef68d8ce34e6835fe215619950b05ac88331b Mon Sep 17 00:00:00 2001
> From: Nohee Ko <noheek at broadcom.com>
> Date: Wed, 29 Sep 2010 14:49:03 -0700
> Subject: [PATCH 370/370] staging:brcm80211:fix #ifdef BRCM_FULLMAC mess
> 
> 
> Signed-off-by: Nohee Ko <noheek at broadcom.com>

What's with putting another header in the message?  And patch 370/370?
Me thinks you need to read the 'git format-patch' man page :)

I'll fix it up this time, but please, in the future, get this correct, I
don't like editing every patch header by hand, it doesn't scale.

thanks,

greg k-h



More information about the devel mailing list