[PATCH 8/9] staging: brcm80211: fix checkpatch error 'assignment in if condition'

jason jason at lakedaemon.net
Thu Sep 30 17:00:37 UTC 2010


Henry Ptasinski wrote:
> Jason,
> 
> It looks like tabs have been converted to spaces in this patch, even in the
> unchanged code.  git am doesn't like it, but it applies fine with patch -l.
> None of the other patches in this series seem to have an issue (but patch
> 8 in v2 has the same problem).
> 

Do you have the line numbers of a few examples?  I looked at my version of wl_iw.c and nothing jumped out at me...

> Or is that my email system doing strange things again?
> 

Postfix and Mutt aren't known for doing that though.  It's more likely that the original code had some bad white space voodoo.  If so, those are pretty far down there on the list of cleanups.  Unless it makes merging patches a pia, then we can move it to the top of the list...

thx,

Jason.




More information about the devel mailing list