Build failures with the brcmfmac driver

Greg KH greg at
Fri Sep 24 00:14:02 UTC 2010

On Thu, Sep 23, 2010 at 04:45:08PM -0700, Henry Ptasinski wrote:
> On 09/23/2010 04:35 PM, Greg KH wrote:
> >On Thu, Sep 23, 2010 at 04:18:47PM -0700, Greg KH wrote:
> >>Are you all crazy to enable "treat warnings like errors"?
> Yes. :-)

Heh, well, I just disabled that, as much as you think you want it, you
really don't, given the huge range of versions of gcc out there.

> >So, for now, you should change the Kconfig file to only allow the
> >selection of one of the kernel drivers at once.  Not the "real" fix, but
> >it should be good enough for the moment.
> I was just working on that.  See below for rough cut at new Kconfig.
> One issue I'm seeing: make oldconfig just blows through the choices.

That's because you aren't changing the Kconfig option name.

> Is there any way to get it to stop for user input?  Or is the choice
> only available when doing make menuconfig?  Other approaches to make
> the two exclusive?

A "choice" like you did should be fine, odd that 'make oldconfig'
doesn't pick it up.  Ah, I bet it did, does it just keep the first one
you happened to have selected and drop the other one?  If so, that's

> >Unless you have a better idea?
> Longer term, cleanout utils and anything that's left becomes a
> separate module that's only compiled once?  Other suggestions?

Yes, that's the correct thing to do, after the #ifdef stuff is handled.

> >Oh, ideally we will just get rid of the #define mess, but as you have 2
> >drivers depending on two different set of options, it's not going to be
> >a simple task unwinding it...
> Nohee is working on cleaning out lots of the #ifdefs, and removing
> the duplicate files.

Please, send patches as soon as possible so that people don't get
conflicts as others are starting to work on this code at the same time
(myself included.)

And remember, I need one-patch-per-change, so no big "this removes all
the ifdefs" type patch please.


greg k-h

More information about the devel mailing list