[PATCH] staging: fix possible use-before-NULL-check crash

Kees Cook kees.cook at canonical.com
Wed Oct 6 22:39:41 UTC 2010


Found via http://coccinelle.lip6.fr/rules/mini_null_ref.cocci

Signed-off-by: Kees Cook <kees.cook at canonical.com>
---
 drivers/staging/tm6000/tm6000-alsa.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/tm6000/tm6000-alsa.c b/drivers/staging/tm6000/tm6000-alsa.c
index 087137d..c1aff0e 100644
--- a/drivers/staging/tm6000/tm6000-alsa.c
+++ b/drivers/staging/tm6000/tm6000-alsa.c
@@ -426,10 +426,11 @@ error:
 
 static int tm6000_audio_fini(struct tm6000_core *dev)
 {
-	struct snd_tm6000_card	*chip = dev->adev;
+	struct snd_tm6000_card	*chip;
 
 	if (!dev)
 		return 0;
+	chip = dev->adev;
 
 	if (!chip)
 		return 0;
-- 
1.7.1


-- 
Kees Cook
Ubuntu Security Team



More information about the devel mailing list