[PATCH 0/9 v4] staging: brcm80211: fix assignments in if conditon

Greg KH greg at kroah.com
Tue Oct 5 17:40:24 UTC 2010


On Tue, Oct 05, 2010 at 12:43:47PM -0400, jason wrote:
> Greg,
> 
> Greg KH wrote:
> >On Thu, Sep 30, 2010 at 03:15:32PM -0400, Jason Cooper wrote:
> >>Jason Cooper (9):
> >>  staging: brcm80211: fix checkpatch error 'assignment in if condition'
> >>  staging: brcm80211: fix checkpatch error 'assignment in if condition'
> >>  staging: brcm80211: fix checkpatch errors 'assignment in if
> >>    condition'
> >>  staging: brcm80211: fix checkpatch error 'assignment in if condition'
> >>  staging: brcm80211: fix checkpatch error 'assignment in if condition'
> >>  staging: brcm80211: fix checkpatch error 'assignment in if condition'
> >>  staging: brcm80211: fix checkpatch error 'assignment in if condition'
> >>  staging: brcm80211: fix checkpatch error 'assignment in if condition'
> >>  staging: brcm80211: fix checkpatch error 'assignment in if condition'
> >
> >In the future, please use a unique "Subject" line, not all the same
> >thing, as it really isn't that descriptive in the end :)
> >
> 
> No problem, the only differences between them were they each operated
> on a separate file.  In the future, would you want them all grouped as
> one?  I didn't do that this time because it would have been one large
> patch and, I thought, difficult to review.

Just list the filename as part of the subject:
	staging: brcm80211: foo.c: fix checkpatch error 'assignment in if condition'

That makes it unique and a bit more descriptive.

thanks,

greg k-h



More information about the devel mailing list