[PATCH] staging: lis331dlh: add lis331dlh driver

Guenter Roeck guenter.roeck at ericsson.com
Thu Nov 18 16:51:00 UTC 2010


On Thu, Nov 18, 2010 at 11:27:35AM -0500, Jonathan Cameron wrote:
> On 11/10/10 17:12, Carmine IASCONE wrote:
> > Thanks you both for the feedback.
> > 
> > Best regards,
> > Carmine
> > 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh at suse.de] 
> > Sent: Wednesday, November 10, 2010 5:04 PM
> > To: Carmine IASCONE
> > Cc: Jiri Slaby; Matteo DAMENO; devel at driverdev.osuosl.org; linux-kernel at vger.kernel.org; mems applications; Alan Cox
> > Subject: Re: [PATCH] staging: lis331dlh: add lis331dlh driver
> > 
> > On Wed, Nov 10, 2010 at 04:17:41PM +0100, Jiri Slaby wrote:
> >> On 11/10/2010 12:51 PM, Carmine IASCONE wrote:
> >>> Hi Greg, Hi JS,
> >>> Matteo and I have started to develop linux device drivers for our STMicroelectronics sensors about one year ago. Our main target is the Android platform (mobile phone or tablet pc), and for this reason the drivers are thought to be used on I2C bus. The drivers are enough stable, we have several customers that are using them, and also with the advice of these customers, we would like to make available them for all the linux community, merging them in the kernel upstream to be used in all linux supported platforms.
> >>> The drivers have had a initial review by Alan Cox, that gives us some very precious advices to improve the style and robustness of the drivers. 
> >>> We are newbies in patch generation and submission: we have followed the instructions in the Greg's video on you tube to create this first patch, so sorry if there is something that we missed. We thought to put the driver in staging directory, because before merging them in the main tree we would like to have a general revision, and also because in this first release we haven't managed the device interrupts yet. At the end the right position for these drivers could be drivers/input/misc.
> >>> How do we proceed now? Do we need to generate a new patch adding the TODO file? Please advice.
> >>
> >> Hi, well, I don't think this should go into staging at all as I think
> >> it's clean enough to go upstream directly (but I repeat I'm no IIC
> >> expert). So please resend to IIC people:
> >> I2C SUBSYSTEM
> >> M:      "Jean Delvare (PC drivers, core)" <khali at linux-fr.org>
> >> M:      "Ben Dooks (embedded platforms)" <ben-linux at fluff.org>
> >> L:      linux-i2c at vger.kernel.org
> >>
> >> but before that, move that out of staging to drivers/i2c/ (or anywhere
> >> where it make sense).

drivers/i2c doesn't sound right; that is for i2c infrastructure.

> >>
> >> It's perfectly OK to add functionality later (IRQs).
> > 
> > I agree, this should be sent to Jean and the i2c developers first.
> > Please work to get your driver into the main tree, only use staging as a
> > last-resort if you have a lot of work left to do on the code.
> I haven't done a proper datasheet trawl, but this looks like it is probably
> already supported by the lis3lv02 driver (currently still in hwmon I think?)

Yes, it is still in hwmon.

> This driver will move fairly soon (or may already have done so).
> 
Not yet.

> lis331dl is listed in the header as supported and naming if nothing else suggests
> to me that this part will be similar. If this driver has additional functionality
> I would suggest adding it to that driver rather than starting again.
> 
Agreed.

Thanks,
Guenter



More information about the devel mailing list