[patch] Staging: bcm: signedness bug in InitCardAndDownloadFirmware()

Dan Carpenter error27 at gmail.com
Sat Nov 13 08:24:22 UTC 2010

status is used to store negative error codes throughout.  The only place
where this is a runtime bug is if create_worker_threads() fails. 

Signed-off-by: Dan Carpenter <error27 at gmail.com>

diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index 1bb6a1d..440b9cd 100644
--- a/drivers/staging/bcm/Misc.c
+++ b/drivers/staging/bcm/Misc.c
@@ -1079,7 +1079,7 @@ int run_card_proc(PMINI_ADAPTER ps_adapter )
 int InitCardAndDownloadFirmware(PMINI_ADAPTER ps_adapter)
+	int status;
 	UINT value = 0;
  	 * Create the threads first and then download the

More information about the devel mailing list