[patch] Staging: rtl8712: signedness bug in init

Larry Finger Larry.Finger at lwfinger.net
Fri Nov 12 13:24:24 UTC 2010

On 11/11/2010 11:11 PM, Dan Carpenter wrote:
> PollingCnt is 20 and that means we loop 20 times and then run the
> timeout code.  After the end of the loop PollingCnt should be -1 but
> because it's an unsigned char, it's actually 255 and the timeout
> code never runs.
> Signed-off-by: Dan Carpenter <error27 at gmail.com>

Acked-by: Larry Finger <Larry.Finger at lwfinger.net>

As a point of interest, did you actually hit a timeout, or was this found by a
code audit?


More information about the devel mailing list