[PATCH 1/4] Staging: comedi: fix brace coding style issue in ni_tio.c This is a patch to the ni_tio.c file that fixes up a brace, indentation and overlines warning found by the checkpatch.pl tool Signed-off-by: Varayud Damian Alfredo <davarayud at gmail.com>

Jiri Slaby jirislaby at gmail.com
Wed Nov 10 15:23:25 UTC 2010


On 11/10/2010 02:20 PM, Damian Varayud wrote:
> @@ -291,21 +296,22 @@ static void __exit ni_tio_cleanup_module(void)
> 
>  module_exit(ni_tio_cleanup_module);
> 
>  struct ni_gpct_device *ni_gpct_device_construct(struct comedi_device *dev,
> -						void (*write_register) (struct
> -									ni_gpct
> -									*
> -									counter,
> -									unsigned
> -									bits,
> -									enum
> -									ni_gpct_register
> -									reg),
> -						unsigned (*read_register)
> -						(struct ni_gpct *counter,
> -						 enum ni_gpct_register reg),
> -						enum ni_gpct_variant variant,
> -						unsigned num_counters)
> +						void (*write_register)
> +						(struct ni_gpct *counter,
> +						 unsigned bits,
> +						 enum ni_gpct_register reg),
> +						unsigned (*read_register)
> +						(struct ni_gpct *counter,
> +						 enum ni_gpct_register reg),
> +						 enum ni_gpct_variant variant,
> +						 unsigned num_counters)

I don't think this looks anyhow saner. What about shifting it left like:
               void (*write_register)(struct ni_gpct *counter,
                        unsigned bits, enum ni_gpct_register reg),
               unsigned (*read_register)(struct ni_gpct *counter,
			enum ni_gpct_register reg),
	       enum ni_gpct_variant variant, unsigned num_counters)

regards,
-- 
js



More information about the devel mailing list