[PATCH] staging:comedi:drivers:poc- fixed comment issue giving annoying warnings

Greg KH gregkh at suse.de
Mon Nov 8 01:42:09 UTC 2010


On Sun, Nov 07, 2010 at 07:51:28PM -0500, Henry Eshbaugh wrote:
> >From 1ad8af3b51b51ea253923d2fe4180efda337c2cd Mon Sep 17 00:00:00 2001
> From: Henry Eshbaugh <newts500 at gmail.com>
> Date: Sat, 6 Nov 2010 10:23:53 -0400
> Subject: [PATCH] staging:comedi:drivers:poc- fixed comment issue giving
> annoying warnings
> 
> Fixed a comment block with warnings that were annoying checkpatch.pl

Close, but these didn't need to be fixed.

>  /*
> -    comedi/drivers/poc.c
> -    Mini-drivers for POC (Piece of Crap) boards
> -    Copyright (C) 2000 Frank Mori Hess <fmhess at users.sourceforge.net>
> -    Copyright (C) 2001 David A. Schleef <ds at schleef.org>
> -
> -    This program is free software; you can redistribute it and/or
> modify

Your patch is line-wrapped and can't be applied :(

>  Devices: [Keithley Metrabyte] DAC-02 (dac02), [Advantech] PCL-733
> (pcl733),
> -  PCL-734 (pcl734)
> +PCL-734 (pcl734)

No need to change this.

>  Updated: Sat, 16 Mar 2002 17:34:48 -0800
> Status: unknown 
> This driver is indended to support very simple ISA-based devices,
> including:
> - dac02 - Keithley DAC-02 analog output board
> - pcl733 - Advantech PCL-733
> - pcl734 - Advantech PCL-734
> +*  dac02 - Keithley DAC-02 analog output board
> +*  pcl733 - Advantech PCL-733
> +*  pcl734 - Advantech PCL-734
> Configuration options:
>  [0] - I/O port base
> +*  [0] - I/O port base

Or these lines.

>  */
> - #include "../comedidev.h"

Why are you deleting this line?  That would break the build, right?

Remember, checkpatch.pl is a hint, not always correct.

thanks,

greg k-h



More information about the devel mailing list