[PATCH] staging, comedi, das16: das16_attach() needs to free allocated resources on failure

Frank Mori Hess fmhess at speakeasy.net
Sun Nov 7 23:35:23 UTC 2010

On Sunday 07 November 2010, Jesper Juhl wrote:
> Hi,
> In drivers/staging/comedi/drivers/das16.c::das16_attach() there are many
> potential failure scenarios. However, the driver neglects to free
> resources it has allocated if failures happen.

This patch appears to be wrong.  The driver's detach function will be 
called by the core if the attach function returns with an error.  The 
resources are freed there.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20101107/32293553/attachment.asc>

More information about the devel mailing list