[PATCH] staging: batman-adv: Use linux/etherdevice.h address helper functions

Sven Eckelmann sven.eckelmann at gmx.de
Wed Nov 3 11:04:37 UTC 2010


On Wednesday 03 November 2010 11:56:19 Sven Eckelmann wrote:
> On Wednesday 03 November 2010 11:25:12 Tobias Klauser wrote:
> > On 2010-11-03 at 11:12:12 +0100, Sven Eckelmann <sven.eckelmann at gmx.de>
> 
> wrote:
> > > On Wednesday 03 November 2010 10:59:02 you wrote:
> > > > Replace custom ethernet address check functions by calls to the
> > > > helpers in linux/etherdevice.h
> > > 
> > > Have you proven that the addresses are always two bytes aligned in
> > > memory? Afaik this function needs it.
> > 
> > I don't think they need to be two bytes aligned, but I might be wrong.
> 
> compare_ether_addr uses a two byte pointer to access 3x two bytes. This
> makes it necessary to have all those 3 bytes aligned to 2 byte boundaries.

3x two bytes for each ethernet address == 6x two bytes and not 3 bytes... I 
don't know why I wrote that.

Best regards,
	Sven
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20101103/004bdba5/attachment.asc>


More information about the devel mailing list