[PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h to lower cases

Greg KH gregkh at suse.de
Mon Nov 1 18:39:18 UTC 2010


On Mon, Nov 01, 2010 at 06:27:04PM +0000, Haiyang Zhang wrote:
> > From: Greg KH [mailto:gregkh at suse.de]
> > Sent: Monday, November 01, 2010 1:43 PM
> > Why did I get two different copies of some of these patches?  Are they
> > different?
> 
> They are the same.
> Initially, I sent all 10 patches out at the same time, but I only saw 5 of them in my mail box. So I re-sent the 5 missing ones. Half hour later, I found the 5 previous missing emails were not lost, and received again at a later time.

Ah, ok.

Oh, please wrap your emails properly :)

> > >  /* The one and only */
> > > -struct hv_context gHvContext = {
> > > -	.SynICInitialized	= false,
> > > -	.HypercallPage		= NULL,
> > > -	.SignalEventParam	= NULL,
> > > -	.SignalEventBuffer	= NULL,
> > > +struct hv_context g_hv_context = {
> > 
> > What is the "g_" for?  Why are you keeping the unneeded, and unwanted
> > hungarian notation around?  Please don't do that.
> 
> The "g_" was used for global variables. I also saw some other global
> variables with the hungarian notation. Since this notation is not
> related to camel case conversion, how about we remove the hungarian
> notations in a separate patch?

How about you fix this patch in the series and resend them?

And if you look at the kernel, there is no "g_" for global variable
names, so I don't want to see that as part of the history at all.

I'll drop these series and wait for an updated one.

thanks,

greg k-h



More information about the devel mailing list