[PATCH] linux-firmware: brcm: Removed codeversion from firmware filenames.

David Woodhouse dwmw2 at infradead.org
Mon Nov 1 14:28:59 UTC 2010


On Thu, 2010-10-21 at 10:08 -0700, Henry Ptasinski wrote:
> Here's a patch to rename our firmware files in the linux-firmware repo.  I'll
> be sending a complimentary patch to Greg for staging-next-2.6 shortly.
> 
> The basename-apiversion-codeversion construction for firmware filenames is not
> used by most other firmware files, adds complexity, and is not providing any
> value.  Rename the firmware files using just basename-apiversion. 

Please use the '-M' option to git diff (or whatever you're using) to
make it detect renames -- the resulting patch would be a lot shorter.

And also please ensure the filenames listed in the WHENCE file are all
correct. You don't seem to have fixed those to reflect your changes. And
in fact I think the WHENCE file is *already* listing the bcm4329 files
in the wrong directory?

-- 
dwmw2




More information about the devel mailing list